doc: improve the doc of the 'information' event#27009
Closed
lpinca wants to merge 1 commit intonodejs:masterfrom
Closed
doc: improve the doc of the 'information' event#27009lpinca wants to merge 1 commit intonodejs:masterfrom
lpinca wants to merge 1 commit intonodejs:masterfrom
Conversation
nodejs-github-bot
added
doc
- Add missing argument - Reword a sentence - Rename the `res` argument to `info` in the example to avoid confusion Fixes: nodejs#26905
BridgeAR
approved these changes
Mar 31, 2019
BridgeAR
added
the
author ready
Member
danbev
approved these changes
Apr 2, 2019
Contributor
|
Landed in 0a5a762. |
BethGriggs
pushed a commit
that referenced
this pull request
Apr 9, 2019
- Add missing argument - Reword a sentence - Rename the `res` argument to `info` in the example to avoid confusion PR-URL: #27009 Fixes: #26905 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
BethGriggs
pushed a commit
that referenced
this pull request
Apr 9, 2019
- Add missing argument - Reword a sentence - Rename the `res` argument to `info` in the example to avoid confusion PR-URL: #27009 Fixes: #26905 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Apr 10, 2019
- Add missing argument - Reword a sentence - Rename the `res` argument to `info` in the example to avoid confusion PR-URL: #27009 Fixes: #26905 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resargument toinfoin the example to avoid confusionFixes: #26905
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes